On 27/03/24 20:28, Mark Brown wrote: > On Wed, Mar 27, 2024 at 04:16:52PM +0530, Vijendar Mukunda wrote: > >> @@ -115,7 +115,10 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id >> goto unregister_dmic_dev; >> } >> >> - acp_init(chip); >> + ret = acp_init(chip); >> + if (ret) >> + return ret; >> + > The return check is good but shouldn't this be a 'goto > unregister_dmic_dev' like the above case so we do cleanup? I do agree. Will modify the code and respin the patch series.
