Mon, Mar 25, 2024 at 05:01:18PM -0500, Pierre-Louis Bossart kirjoitti: ... > > + dev_dbg(tas_priv->dev, "%s: %d\n", __func__, > > Nit-pick: you don't need to add __func__ to dev_dbg logs, the user can > add the information with the dyndbg parameter, e.g. > > options snd_intel_dspcfg dyndbg=+pmf > > dev_err/warn don't have this functionality though so in those cases > there's no replacement for __func__ You beat me up to it, I just downloaded the email thread to say the same. Since I'm here, I think __func__ in dev_err()/dev_warn() usually says about poorly written message itself (that it's not unique enough to distinguish taking into account that this has device instance name as well). While pr_*() ones indeed may benefit from having it. -- With Best Regards, Andy Shevchenko
