HI Bastien,
On 20/03/2024 09:31, Bastien Curutchet wrote:
>>> + if ((dev->tdm_slots || dev->slot_width) &&
>>> + ((fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) !=
>>> SND_SOC_DAIFMT_BP_FC)) {
>>> + dev_err(dev->dev, "TDM is only supported for BP_FC format\n");
>>> + return -EINVAL;
>>
>> I think this is not a valid statement, Fsync can be generated internally
>> or coming from external source in TDM mode also.
>>
>
> My hardware allow me to only test BP_FC so I wished to put some
> 'barriers' in front of untested things.
I don't see restrictions on the other changes affecting this to be lifted.
I would allow TDM for full clock provider mode also.
>
>
> Best regards,
> Bastien
--
Péter
