On 15/03/2024 00:21, Jan Dakinevich wrote: > This option allow to redefine the rate of DSP system clock. And why is it suitable for bindings? Describe the hardware, not what you want to do in the driver. > > Signed-off-by: Jan Dakinevich <jan.dakinevich@xxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/sound/amlogic,axg-pdm.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-pdm.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-pdm.yaml > index df21dd72fc65..d2f23a59a6b6 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,axg-pdm.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-pdm.yaml > @@ -40,6 +40,10 @@ properties: > resets: > maxItems: 1 > > + sysrate: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: redefine rate of DSP system clock No vendor prefix, so is it a generic property? Also, missing unit suffix, but more importantly I don't understand why this is a property of hardware. Best regards, Krzysztof
