On Tue 12 Mar 2024 at 13:51, Mark Brown <broonie@xxxxxxxxxx> wrote: > [[PGP Signed Part:Undecided]] > On Tue, Mar 12, 2024 at 01:36:47AM +0000, Kuninori Morimoto wrote: > >> Hmm... >> does it have un-cleared "dai_link->ch_maps" ? > >> Thank you for your help !! > > I can't immediately see where ch_maps would get set for this board (it > looks like Intel is the only user?) but I might be missing something. I > don't have the board myself so can't run anything directly - Jerome? This board (the u200 reference design) does not have anything particular compared to other Amlogic g12 based design. Not sure I have an u200 with me, I'll check. Mark, I suspect the boards you have (like the libretech Alta/Solitude or the kvim3 maybe) will show the same thing. The axg sound card (sound/soc/meson/axg-card.c) does not touch ch_maps. This cards uses a few tricks to deal with this rather complicated HW. Off the top of my head, maybe the following could complicate things for this rework: * dai_links are allocated with krealloc because we need to add links for the TDM loopbacks. Whether or not loopback are needed is only known halfway through the parsing of DT. Still, __GFP_ZERO is used, so ch_maps should be cleared - so I doubt this is the problem * In addition to DPCM, the card uses "Codec 2 Codec" links. IOW, there is 2 layers of links with '.no_pcm = 1'. This is necessary because there another layer of digital routing past the DPCM backends (basically a mux between the TDM backends and internals codecs, like HDMI). Maybe this does not play well with this patch series. I can't really test right now, sorry. I can check and test further later this week. > > [[End of PGP Signed Part]] -- Jerome
