Hi Takashi > > A quick glance at the codebase shows: > > > > AC_PINCTL* long form: > > patch_conexant.c > > patch_realtek.c > > patch_sigmatel.c > > > > /PIN_(VREF|IN|OUT|HP)/ > > hda_codec.c > > patch_analog.c > > patch_atihdmi.c > > patch_cmedia.c > > patch_conexant.c > > patch_realtek.c > > patch_sigmatel.c > > patch_via.c > > > > Raw hex for AC_VERB_SET_PIN_WIDGET_CONTROL verbs: > > patch_analog.c > > patch_realtek.c (LOTS) > > patch_via.c (LOTS) > > > > The raw hex ones SHOULD be replaced, but the rest of them I'm not fussed either > > way. Takashi can make a decision as to which variant is preferred, I don't mind > > doing the cleanup. > > Robin's patch is a right improvement wrt readability for whom are not > familiar with HD-audio codec spec, so I applied it as is. I have no problem with this so long as it hasn't broken anything. I can't easily test this myself until I return from LPC. > FWIW, AC_* and PIN_* have somewhat different fields: the former is the > definition of each bit, and the latter is the values used in the real > world. Thanks - that's very succintly put. :-) Regards jonathan _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
