On Tue, Feb 27, 2024 at 6:27 PM Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote: > > This looks much better than v1. Make sure you have addressed all > comments from the previous version > and add a short log under the scissor line explaining what you have changed. > > Few comments inline: > > > On Tue, Feb 27, 2024 at 6:13 PM Javier García <javier.garcia.ta@xxxxxxxx> wrote: > > > > Convert the Imagination Technologies SPDIF Input Controllerto DT schema. > > > > Signed-off-by: Javier García <javier.garcia.ta@xxxxxxxx> > > --- > ^ this is the scissor line. Here you add the change log. > > Changes since v1: > - re-written the subject inline to include relevant prefix > - removed header file as it is not used > - ....etc > > > > +$id: http://devicetree.org/schemas/sound/img,spdif-in.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Imagination Technologies SPDIF Input Controller > > + > > +maintainers: > > + - Liam Girdwood <lgirdwood@xxxxxxxxx> > > + - Mark Brown <broonie@xxxxxxxxxx> > > Please do not blindly add people here. The most proper candidate for this > is the people who wrote the original file. > > Using git log we can find Damien.Horsley <Damien.Horsley@xxxxxxxxxx> Looks like this address bounced back. @Krzysztof Kozlowski @Mark Brown is it OK to add a mailing list as maintainer for a yml file?
