On Tue, Feb 13, 2024, at 11:36, Jerome Brunet wrote: > On Tue 13 Feb 2024 at 11:11, Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > This probably pre-dates the introduction of devm_clk_get_enabled() > It would probably be better to use that instead of duplicating helper > functions which do the same thing. Ah, I had not thought of that interface either, so you are probably right that this is the best way to do it. Can you send a replacement patch then and add my Reported-by? I also sent the same patch for drivers/nvmem/meson-efuse.c, which I guess will also need the same treatment. I also checked and saw that all three files already had this code in linux-6.0 when devm_clk_get_enabled() got added. > If for any reason it is not possible, a common helper in clk.h would > preferable I think. I can't think of anything that prevents us from using devm_clk_get_enabled() here. Arnd