On Wed, Jan 24, 2024 at 6:56 PM Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote: > > Use more forward declarations, move header guards to cover other > includes, and rely less on including headers through other headers. ... > +struct device; > +struct cs42l43; > +struct snd_soc_component; > +struct snd_soc_jack; > +struct clk; I would keep it sorted and grouped (in similar way how headers can be done, i.e. from more generic towards custom and local), like struct clk; struct device; struct snd_soc_component; struct snd_soc_jack; struct cs42l43; -- With Best Regards, Andy Shevchenko
