On 1/22/24 16:15, Maciej Strozek wrote: It wouldn't hurt to add a brief commit message describing what the hardware layout is, specifically how the mics are handled. It's also best to submit the corresponding machine driver updates at the same time to check for consistency. > }, > + { > + .link_mask = BIT(0) | BIT(2) | BIT(3), > + .links = cs42l43_link0_cs35l56_link2_link3, > + .drv_name = "sof_sdw", > + .sof_tplg_filename = "sof-mtl-cs42l43-l0-cs35l56-l23.tplg", was this topology submitted to the SOF tree? I don't see it, usually we review topology/acpi/machine stuff together to avoid disconnects. > + }, > { > .link_mask = GENMASK(2, 0), > .links = mtl_cs42l43_cs35l56, > -- > 2.34.1 >