On 10/01/24 15:14, Vijendar Mukunda wrote: > This patch series is to redesign existing platform device creation logic > for SoundWire managers and Implement generic functions for SoundWire > manager probe, start and exit sequence which are common for both Legacy > (NO DSP enabled) and SOF stack, and add SoundWire Interface support for AMD > SOF stack (ACP 6.3 based platform). > > Below patch series is reviewed in > https://github.com/thesofproject/linux/pull/4699 > > Changes since V1: > - add new commit to update license for amd soundwire manager > driver files. > - wrap the commit message with in 75 characters. > - add amd tag in commit title for soundwire patches > > This patch series has dependencies. > > "drivers: soundwire: amd: refactor amd soundwire manager device node > creation" patch has dependency on below patch. > > "ASoC/soundwire: implement generic api for scanning amd soundwire > controller" > > Similarly SOF patches has dependency on Soundwire tree patches. > This patch series has to be reviewed and merged in one go. > Hi Vinod, Could you please review SoundWire patches? - Vijendar > Vijendar Mukunda (13): > ASoC/soundwire: implement generic api for scanning amd soundwire > controller > drivers: soundwire: amd: update license > drivers: soundwire: amd: refactor amd soundwire manager device node > creation > drivers: soundwire: amd: implement function to extract slave > information > drivers: soundwire: amd: refactor soundwire pads enable > drivers: soundwire: amd: refactor register mask structure > ASoC: SOF: amd: add code for invoking soundwire manager helper > functions > ASoC: SOF: amd: add interrupt handling for SoundWire manager devices > ASoC: SOF: amd: Add Soundwire DAI configuration support for AMD > platforms > ASoC: SOF: amd: add machine select logic for soundwire based platforms > ASoC: SOF: amd: update descriptor fields for acp6.3 based platform > ASoC: SOF: amd: select soundwire dependency flag for acp6.3 based > platform > ASoC: SOF: amd: refactor acp driver pm ops > > drivers/soundwire/Makefile | 2 +- > drivers/soundwire/amd_init.c | 235 +++++++++++++++++++++++++++++ > drivers/soundwire/amd_init.h | 13 ++ > drivers/soundwire/amd_manager.c | 45 ++---- > drivers/soundwire/amd_manager.h | 14 +- > include/linux/soundwire/sdw_amd.h | 81 ++++++++-- > include/sound/sof/dai-amd.h | 7 + > include/sound/sof/dai.h | 2 + > include/uapi/sound/sof/tokens.h | 4 + > sound/soc/amd/acp/Kconfig | 7 + > sound/soc/amd/acp/Makefile | 2 + > sound/soc/amd/acp/amd-sdw-acpi.c | 62 ++++++++ > sound/soc/sof/amd/Kconfig | 18 +++ > sound/soc/sof/amd/acp-common.c | 65 +++++++- > sound/soc/sof/amd/acp-dsp-offset.h | 10 ++ > sound/soc/sof/amd/acp.c | 202 ++++++++++++++++++++++++- > sound/soc/sof/amd/acp.h | 26 +++- > sound/soc/sof/amd/pci-acp63.c | 7 + > sound/soc/sof/ipc3-pcm.c | 25 +++ > sound/soc/sof/ipc3-topology.c | 40 +++++ > sound/soc/sof/sof-audio.h | 1 + > sound/soc/sof/topology.c | 5 + > 22 files changed, 802 insertions(+), 71 deletions(-) > create mode 100644 drivers/soundwire/amd_init.c > create mode 100644 drivers/soundwire/amd_init.h > create mode 100644 sound/soc/amd/acp/amd-sdw-acpi.c >