On Tue, 02 Jan 2024 10:25:00 +0100, Takashi Iwai wrote: > > On Tue, 02 Jan 2024 10:08:47 +0100, > Péter Ujfalusi wrote: > > > > > > > > On 30/12/2023 12:03, Takashi Iwai wrote: > > > On Sat, 30 Dec 2023 08:27:43 +0100, > > > Dominik Brodowski wrote: > > >> > > >> Am Fri, Dec 29, 2023 at 06:11:43PM +0100 schrieb Takashi Iwai: > > >>> On Fri, 29 Dec 2023 16:24:18 +0100, > > >>> Dominik Brodowski wrote: > > >>>> > > >>>> Hi Takashi, > > >>>> > > >>>> many thanks for your response. Your patch helps half-way: the oops goes > > >>>> away, but so does the sound... With your patch, the decisive lines in dmesg > > >>>> are: > > >>>> > > >>>> sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864 > > >>>> sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0 > > >>>> sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered > > >>>> sof_sdw sof_sdw: snd_soc_register_card failed -517 > > >>>> sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered > > >>>> sof_sdw sof_sdw: snd_soc_register_card failed -517 > > >>>> platform sof_sdw: deferred probe pending > > >>>> > > >>>> With a revert of the a0575b4add21, it is: > > >>>> > > >>>> sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864 > > >>>> sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0 > > >>>> sof-audio-pci-intel-tgl 0000:00:1f.3: Topology: ABI 3:22:1 Kernel ABI 3:23:0 > > >>>> sof_sdw sof_sdw: ASoC: Parent card not yet available, widget card binding deferred > > >>>> sof_sdw sof_sdw: hda_dsp_hdmi_build_controls: no PCM in topology for HDMI converter 3 > > >>>> input: sof-soundwire HDMI/DP,pcm=5 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input14 > > >>>> input: sof-soundwire HDMI/DP,pcm=6 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input15 > > >>>> input: sof-soundwire HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input16 > > >>>> > > >>>> Maybe this helps a bit further? > > >>> > > >>> Thanks for quick testing. > > >>> It shows at least that my guess wasn't wrong. > > >>> > > >>> The problem could be the initialization order in the caller side. > > >>> Can the patch below work instead? > > >> > > >> Unfortunately, no: > > >> > > >> sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864 > > >> sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0 > > >> sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered > > >> sof_sdw sof_sdw: snd_soc_register_card failed -517 > > >> sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered > > >> sof_sdw sof_sdw: snd_soc_register_card failed -517 > > >> platform sof_sdw: deferred probe pending > > > > > > Hm, then it might be the logical failure of that commit. > > > Peter? > > > > > > Without a fix in the next few days, we'll have to revert it before > > > 6.7. > > > > The fix for this was sent early December: > > https://lore.kernel.org/linux-sound/20231207095425.19597-1-peter.ujfalusi@xxxxxxxxxxxxxxx/ > > > > It had the correct Fixes tag but it did not made it to 6.7-rc while > > a0575b4add21 did made it. > > > > Mark, Takashi, can you pick the fix for 6.7 (it is in -next)? I think we > > might have time for it to land? > > Oh that landed to Mark's for-next branch, i.e. only for 6.8. > Mark, please cherry-pick and send a PR before 6.7 final. I ended up with cherry-picking by myself now. I'm going to send a PR to Linus for 6.7 final in tomorrow. thanks, Takashi
