On Mon, Sep 08, 2008 at 01:06:13PM +0400, Dmitry Baryshkov wrote:
> +#include <linux/platform_device.h>
> +#include <sound/ac97_codec.h>
ac97_codec.h should've been added earlier on in the patch series - this
patch doesn't add a new requirement for ac97.
The same thing appears to apply to platform_device.h if it's required at
all.
> config SND_PXA2XX_LIB
> tristate
> - select SND_AC97_CODEC
> + select SND_AC97_CODEC if SND_PXA2XX_LIB_AC97
> +
> +config SND_PXA2XX_LIB_AC97
> + bool
>
> config SND_PXA2XX_AC97
> tristate "AC97 driver for the Intel PXA2xx chip"
> depends on ARCH_PXA
> select SND_PXA2XX_PCM
> - select SND_PXA2XX_LIB
> + select SND_PXA2XX_LIB_AC97
> help
> Say Y or M if you want to support any AC97 codec attached to
> the PXA2xx AC97 interface.
> obj-$(CONFIG_SND_PXA2XX_LIB) += snd-pxa2xx-lib.o
> -snd-pxa2xx-lib-objs := pxa2xx-ac97-lib.o
> +snd-pxa2xx-lib-y := pxa2xx-pcm-lib.o
> +snd-pxa2xx-lib-$(CONFIG_SND_PXA2XX_LIB_AC97) += pxa2xx-ac97-lib.o
> +EXPORT_SYMBOL(__pxa2xx_pcm_hw_params);
Hrm. The existing ASoC stuff is all EXPORT_SYMBOL_GPL(), as much on the
basis of potential churn as anything else. Especially for the __
functions it might be nice to preserve that.
> +EXPORT_SYMBOL(pxa2xx_pcm_free_dma_buffers);
> +
> +MODULE_AUTHOR("Nicolas Pitre");
> +MODULE_DESCRIPTION("Intel PXA2xx sound library");
> +MODULE_LICENSE("GPL");
Probably as well to drop the Intel here :)
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
