Re: [PATCH v2 2/2] ALSA: hda: cs35l41: Support Dell XPS 9530 (2023)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 20/12/2023 07:38, Aleksandrs Vinarskis wrote:
Add new model entries into configuration table.

Co-developed-by: Jasper Smet <josbeir@xxxxxxxxx>
Signed-off-by: Jasper Smet <josbeir@xxxxxxxxx>
Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx>
---
  sound/pci/hda/cs35l41_hda_property.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index cb305b093311..ee105743333f 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -41,6 +41,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
   * Since this laptop has valid ACPI, we do not need to handle cs-gpios, since that already exists
   * in the ACPI. The Reset GPIO is also valid, so we can use the Reset defined in _DSD.
   */
+	{ "10280BEB", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },

The configuration is correct, however the comment above it applies to the laptop below, so the entry needs to be above the comment.

I was planning on pushing up a patch myself (hopefully today) which includes this laptop, as well as a couple of other Dell laptops. In the same chain is a patch to prevent firmware loading on systems with slow SPI speed.

It may be wise to wait for those patches instead.

Thanks,

Stefan

  	{ "103C89C6", SPI, 2, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, -1, -1, -1, 1000, 4500, 24 },
  	{ "104312AF", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
  	{ "10431433", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -355,6 +356,7 @@ struct cs35l41_prop_model {
  static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
  	{ "CLSA0100", NULL, lenovo_legion_no_acpi },
  	{ "CLSA0101", NULL, lenovo_legion_no_acpi },
+	{ "CSC3551", "10280BEB", generic_dsd_config },
  	{ "CSC3551", "103C89C6", generic_dsd_config },
  	{ "CSC3551", "104312AF", generic_dsd_config },
  	{ "CSC3551", "10431433", generic_dsd_config },



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux