On Thu, Dec 14, 2023 at 04:49:23PM +0100, Takashi Iwai wrote: > On Thu, 14 Dec 2023 16:39:58 +0100, > Stuart Henderson wrote: > > On 14/12/2023 11:02, Takashi Iwai wrote: > > > On Tue, 12 Dec 2023 20:52:43 +0100, > > > Aleksandrs Vinarskis wrote: ... > > > Can Cirrus team review this? > > The patch looks sensible, with some minor comments below, however > > we're just at the tail end of testing a patch chain that genericises a > > lot of this code and adds support for a rather large batch of other > > laptops with incomplete DSD. We're hoping to push this upstream on > > Monday. > > > > Can I be awkward and ask that we hold off on this patch chain until > > then? Then we can add this laptop using the new approach. > > > > If/when the chain is accepted, we will add support for a few Dell > > laptops as well, including this one. > > It's fine to wait for a while for me. > Hopefully we can make it in 6.7, and we can catch up in the next > week. > > (BTW, I'll be off from the next Tuesday, and the reply will be > delayed, but I can eventually check and merge patches remotely :) Since v6.7 is going to be an LTS, I think we are eagerly want to have one or the other to be included. In case Cirrus is slow with their patch, I would like to see this one being included. Let's make an xmas/ny gift to all users of this codec! -- With Best Regards, Andy Shevchenko