On 09/12/2023 09:30, Ding, Shenghao wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Saturday, December 9, 2023 4:13 PM >> To: Ding, Shenghao <shenghao-ding@xxxxxx>; broonie@xxxxxxxxxx >> Cc: robh+dt@xxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; >> lgirdwood@xxxxxxxxx; perex@xxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; >> 13916275206@xxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; linux- >> kernel@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxx; soyer@xxxxxx; >> tiwai@xxxxxxx >> Subject: [EXTERNAL] Re: [PATCH v1 3/3] ASoC: dt-bindings: Add tas2563 into >> yaml >> >> On 09/12/2023 09:07, Shenghao Ding wrote: >>> Support tas2563. >>> >>> Signed-off-by: Shenghao Ding <shenghao-ding@xxxxxx> >>> --- >>> .../devicetree/bindings/sound/ti,tas2781.yaml | 17 ++++++++++------- >>> 1 file changed, 10 insertions(+), 7 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml >>> b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml >>> index a69e6c223308..84e197e15df4 100644 >>> --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml >>> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml >>> @@ -11,11 +11,11 @@ maintainers: >>> - Shenghao Ding <shenghao-ding@xxxxxx> >>> >>> description: >>> - The TAS2781 is a mono, digital input Class-D audio amplifier >>> - optimized for efficiently driving high peak power into small >>> - loudspeakers. An integrated on-chip DSP supports Texas Instruments >>> - Smart Amp speaker protection algorithm. The integrated speaker >>> - voltage and current sense provides for real time >>> + The TAS2781/TAS2563 is a mono, digital input Class-D audio >>> + amplifier optimized for efficiently driving high peak power into >>> + small loudspeakers. An integrated on-chip DSP supports Texas >>> + Instruments Smart Amp speaker protection algorithm. The integrated >>> + speaker voltage and current sense provides for real time >>> monitoring of loudspeaker behavior. >>> >>> allOf: >>> @@ -25,16 +25,19 @@ properties: >>> compatible: >>> enum: >>> - ti,tas2781 >>> + - ti,tas2563 >> >> Looks like devices are compatible, so express it in the bindings with a fallback >> and drop driver patches. > Exactly. Do you mean combine the three patches into one patch? No, driver changes should be dropped - I do not see their value. Compatibility should be expressed in the bindings. Look at example-schema (and hundreds of other bindings). Best regards, Krzysztof
