Re: [PATCH alsa-ucm-conf v2 2/2] sof-soundwire: Add basic support for a 4x cs35l56 configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06. 12. 23 15:05, Charles Keepax wrote:
cs35l56 is a boosted speaker amp, add UCM support for configurations
with up to 8 amps. This also updates the default naming for the
speaker amp UCM file to remove the number of amps. Special cases are
added for the existing amps that require different UCM for different
numbers of amps, but future additions will defaults to not including
it in the naming.

Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
---

...

-	False.Include.spkdev.File "/sof-soundwire/${var:SpeakerCodec1}-${var:SpeakerAmps1}.conf"

Thanks, but I meant to do a global change like this:

https://github.com/alsa-project/alsa-ucm-conf/pull/370

Could you rebase your change on top?

Also, conditions may use ${var:SpeakerAmps1} for consistency. The driver should report the correct configuration. Macros are also helpful to reduce repeating configuration blocks.

				Thanks,
					Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux