On Sun, Nov 19, 2023 at 09:54:32AM +0100, Oliver Sieber wrote: > Hi, > > in the following I provide my proposed patch for the bug report on Bugzilla > [1]. Let me quote from it: > > Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. > > My audio output is fine but my internal microphone cannot be found. > > > > Running `dmidecode` yields: > > > > Handle 0x000F, DMI type 1, 27 bytes > > System Information > > Manufacturer: LENOVO > > Product Name: 20XGS1KT02 > > Version: ThinkPad T14s Gen 2a > > > > Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c? > > > > > > It seems as there have been similar problems in the past, e.g.https://bugzilla.kernel.org/show_bug.cgi?id=216270. > > My proposed diff looks as follows: > > Subject: ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad T14s Gen 2 > From: Oliver Sieber > The ThinkPad T14s Gen 2 laptop does not have the internal digital > microphone connected to the AMD's ACP bridge, but it's advertised > via BIOS. The internal microphone is connected to the HDA codec. > > Use DMI to block the microphone PCM device for this platform. > > Signed-off-by: Oliver Sieber <ollisieber@xxxxxxxxx> > --- > diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c > b/sound/soc/amd/renoir/rn-pci-acp3x.c > index b3812b70f5f9..754e24d55e6f 100644 > --- a/sound/soc/amd/renoir/rn-pci-acp3x.c > +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c > @@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] > = { > DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"), > } > }, > + { > + /* Lenovo ThinkPad T14s Gen 2 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > + DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"), > + } > + }, > {} > > }; > Hi Oliver, Did you forget Takashi's suggestion to follow formal patch submission procedure [1]? Hint: It is suggested to use git-send-email(1) when sending patches, as it handles them as-is (e.g. no wordwrapping, tabs preserved). Thanks. [1]: https://lore.kernel.org/alsa-devel/87sf54jyjl.wl-tiwai@xxxxxxx/ -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature
