On Wed, 08 Nov 2023 11:43:30 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > While re-indenting the first enum, put also axis,artpec8-dw-mshc in > alphabetical order. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/mmc/samsung,exynos-dw-mshc.yaml | 25 ++++++++++++------- > 1 file changed, 16 insertions(+), 9 deletions(-) > Acked-by: Rob Herring <robh@xxxxxxxxxx>
