Takashi Iwai wrote: > One of my concerns in the current pulse code is the many use of > assert(). In many cases, assert() is a wrong choice. For example, > checking the return value of malloc in assert() is definitely wrong. > It should be always checked, and should return an error instead of > aborting the program. > > Yes, alsa-lib has also many assert() although I removed already many. > Some of them may be still wrong ones. Hopefully this can be sorted > out later. There has been a rather large thread on this on PA mailing list over the last couple days :) http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/2014 I personally got some stuff wrong, but learned from Lennart's responses. Certainly I think a lot of the cases where this plugin could have previously hit an assert have now been removed. Not sure about the malloc asserts() tho'... Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mandriva Linux Contributor [http://www.mandriva.com/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
