On Thu, 09 Nov 2023 01:22:57 +0100, vitaly.torshyn@xxxxxxxxx wrote: > > > Hi Takashi, > > Proposed patch fixes initialization of CSC3551 on the UM5302LA laptop. > Patching DSDT table is not required since ASUS did added _DSD entry. > Nothing new introduced but reused work started by Stefan B. > > Currently there is no official firmware available for 10431A83 on cirrus git > unfortunately. > For testing used 104317f3 (which is also seems on i2c bus): > > $ cd /lib/firmware/cirrus/ && \ > for fw in $(find ./ -name '*104317f3*'); do newfw=$(echo $fw | sed 's/104317f3 > /10431a83/g'); echo echo "$fw -> $newfw"; ln -s $f $newfw; done > > With the patch applied to 6.6.0 and obviously symlinks to 104317F3 FW, > speakers works and to my susrprise they sound quite good and loud without > distortion. > > Probably confirmation from cirrus team is needed on firmware. > > Signed-off-by: Vitalii Torshyn <vitaly.torshyn@xxxxxxxxx> Thanks for the patch. The change looks almost fine, but only one thing: > @@ -9937,6 +9943,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1c52, "ASUS Zephyrus G15 2022", ALC289_FIXUP_ASUS_GA401), > SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401), > SND_PCI_QUIRK(0x1043, 0x1f12, "ASUS UM5302", ALC287_FIXUP_CS35L41_I2C_2), > + SND_PCI_QUIRK(0x1043, 0x1a83, "ASUS UM5302LA", ALC294_FIXUP_CS35L41_I2C_2), The entry is sorted in PCI SSID order. Please put at the right position. thanks, Takashi