> This takes some of the work done to auto-configure quirks/routing for > ESS83xx codecs by getting the info from ACPI from: > https://github.com/thesofproject/linux/pull/4112 > > And then builds on top of this to add auto-configuration to > the bytcht_es8316 board driver. Sounds good, thanks for doing this Hans! I only have two minor questions, see below. > > Note compared to the pull-request, which deals with the ES8336, this > series deals with the ES8316 (for which I have several devices to test > on) and this moves all handling from the codec driver to the board > driver where this IMHO belongs. The ACPI stuff is in theory not Intel-specific, so not sure why it would belong in sound/soc/intel/boards? I initially put the code in sound/soc/codecs since the _DSM method is in the scope of the codec device HID. > After this series audio now works properly on a CHT Chuwi Hi12 tablet > without needing to add an extra quirk for that model. > > This has also been tested on the following devices, where things > are unchanged from before (the ACPI autoconfiguration gives the > same results as the old defaults) : > > Onda V80 plus (CHT) > GP-electronic T701 (BYT) > > I also tested this on a Nanote UMPC-01, here the _DSM result > for PLATFORM_SPK_TYPE_ARG wrongly returns 1 (mono) while > the device actually has 2 speakers, so this model needs to keep > its DMI quirk. What about the two others? /* Irbis NB41 */ /* Teclast X98 Plus II */ Are they part of your set of devices and could the quirks be removed?
