On 2023-10-31 9:07 AM, Takashi Iwai wrote:
On Mon, 30 Oct 2023 19:58:52 +0100,
Brady Norander wrote:
The legacy SKL driver no longer works properly on these Chromebook
platforms. Use the new AVS driver by default instead.
Signed-off-by: Brady Norander <bradynorander@xxxxxxxxx>
It's fine to switch to the new and more maintained AVS (once after the
topology is ready), but I wonder how the breakage of SKL happened.
Was it our intentional breakage in the past? If so, why can't we
recover it?
To my knowledge, skylake-driver used in I2S configurations never worked
on "bare" upstream. While I and the team have been sending plethora of
fixes to upstream, it has always been done "after the fact".
Another topic is the topology. Again, from what I know, skylake-driver
topology files were never pushed as an official package to any distro.
In most cases, Chromebook-users were taking what we have done during
recent up-revs for those devices onto their distros. Eventually
avs-topology-xml/for-skylake-driver [1] and avsdk/for-skylake-driver [2]
have been created to help downstream users. While the method is not
perfect, it is certainly better than forcing users to switch to the
avs-driver immediately without addressing any existing skylake-driver
issues.
[1]:
https://github.com/thesofproject/avs-topology-xml/tree/for-skylake-driver
[2]: https://github.com/thesofproject/avsdk/tree/for-skylake-driver
Czarek
