On Fri, Oct 27, 2023 at 11:57:45AM +0100, Srinivas Kandagatla wrote: > Click/Pop Noise was a long pending issue with WSA Codecs which are prone > to accumlate DC when ports are active but without any data streams. > There are multiple places in the current setup, where this could happen > in both startup as well as shutdown path. > > This patchset adds a new flag mute_unmute_on_trigger to dai_ops to let > generic code do the mute/unmute on trigger. > > This patches help fix those issues by making sure the PA is Muted/Unmuted > inline with the stream start/stop events. > > Srinivas Kandagatla (2): > ASoC: soc-dai: add flag to mute and unmute stream during trigger > ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag I've verified that this fixes the pop sounds when starting and stopping a stream on the X13s, even if the click sound when killing pulseaudio (e.g. on reboot) is still there (as with the previous fixes). Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx> If these are accepted, can we get them backported to 6.5 as well? Johan
