Yo,
On Mon, Oct 23, 2023 at 05:36:09AM +0000, Kuninori Morimoto wrote:
> This patch adds ch-maps property to enable handling CPU:Codec = N:M
> connection.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/sound/audio-graph-port.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index 60b5e3fd1115..47f04cdd6670 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -19,7 +19,12 @@ definitions:
> properties:
> mclk-fs:
> $ref: simple-card.yaml#/definitions/mclk-fs
> -
Why have you removed the blank line here?
> + ch-map-idx:
I would rather this be spelt out as "channel-map-index" - although I
don't know if that is the best name for the property, as it seems very
tied to a single operating systems variable names.
I'll leave it to Mark as to whether there is a less linux implementation
coupled name for this property.
> + description: It indicates index of ch_maps array for CPU / Codec if number of
From a bindings perspective, "ch_maps array" is meaningless, as it is
(AFAICT) a linux driver variable name, whereas the property description
needs to describe the hardware alone.
> + CPU(N) / Codec(M) DAIs were not same in one dai-link. ch-map-idx is not needed if the
> + numbers were 1:M or N:1 or N=M. see soc.h::[dai_link->ch_maps Image sample] and
Again, relying on header files in an operating system to explain the
property is not a runner. You need to explain how to populate this
property in an operating system independent manner.
> + ${LINUX}/sound/soc/generic/audio-graph-card2-custom-sample.dtsi. It is good sample.
I'd much rather you added an example to this dt-binding, rather than
pointing off to another location. A proper example will also be able to
be validated by dt-binding-check.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
Blank line here please.
Cheers,
Conor.
> endpoint-base:
> allOf:
> - $ref: /schemas/graph.yaml#/$defs/endpoint-base
> --
> 2.25.1
>
Attachment:
signature.asc
Description: PGP signature
