On 10/19/23 11:43, Mark Hasemeyer wrote: >> I would assume that platform that has DMI_SYS_VENDOR set to "Google", >> also has DMI_BIOS_VERSION set to "Google", so perhaps just replace >> DMI_SYS_VENDOR match with DMI_BIOS_VERSION, to keep table small? Or is >> that not a case? > > That is the case. But I'm inclined to keep it for two reasons: > 1. There is precedent in the kernel to use DMI_SYS_VENDOR=="Google" > for Chromebook detection. > 2. If the coreboot version schema for Chromebooks were to change, this > check would fail for all JSL Chromebooks instead of just a few models. I also prefer a low-risk addition to a higher-risk change. It's not like we really care about the size of the table at this point. Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> FWIW we use this other quirk: DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"), How many engineers does it take to identify a Chromebook, eh?
