On Tue, Sep 2, 2008 at 1:08 PM, Liam Girdwood <lrg@xxxxxxxxxx> wrote: > On Tue, 2008-09-02 at 19:54 +0100, Mark Brown wrote: >> On Tue, Sep 02, 2008 at 09:36:29AM -0700, Steve Sakoman wrote: >> >> > The chip allows 19.2 Mhz, 26 Mhz, or 38.4 Mhz input clocks to the >> > codec. All existing boards (Overo, Beagle, and OMAP3 EVM) use 26 Mhz >> > (generated by a fixed external oscillator chip). I'll check with the >> > Pandora folks, but I believe that they are also 26 Mhz. >> >> OK, a comment to that effect somewhere (perhaps in set_sysclk() which >> only accepts 26MHz) probably wouldn't go amiss. > > The codec set_sysclk() should also accept 19.2MHz and 38.4MHz otherwise > return -EINVAL. It should also have a nice comment too :) It turns out to be fairly trivial to allow the codec to accept all three possibilities. I have added a set_sysck to the codec driver and a call to set_sysclk to 26 Mhz in the overo ASoC driver. This way we can handle future boards that may have chosen one of the other frequencies. Should have things ready for a re-submit later today after some testing. Steve _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
