On Fri, 13 Oct 2023 09:08:12 +0800, Bard Liao wrote: > The same logic is used for clock stop prepare and deprepare, and > having different logs for the two steps helps identify problems. > > In addition, when the "NotFinished" bit remains set, the error > handling is not quite right: > > a) for the clock stop prepare, the error is handled at the caller > level, and the error is ignored: there's no good reason to prevent the > pm_runtime suspend from happening. Throwing an error that is later > ignored is confusing. > > [...] Applied, thanks! [1/1] soundwire: bus: improve error handling for clock stop prepare/deprepare commit: ff435da4cc8b6137be9f0b6b4a9af095590d4b8c Best regards, -- ~Vinod