On 10/7/23 07:43, Brett Worth wrote: > The Dell XPS 9530, like previous XPS laptops like the 9520 and 9510 have > dual speakers in each channel. > > If the ALC289_FIXUP_DUAL_SPK flag is not set in > sound/pci/hda/patch_realtek.c only the tweeter will work and therefore > make the sound quality terrible. > > This patch has not been tested but is derived from a previous patch > attempt from a different user called Pentracillin which was rejected. This looks like the same issue posted here https://github.com/thesofproject/linux/issues/4624. I added a link to see if others can test. > $ diff -r -up a b > diff -r -up a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > --- a/sound/pci/hda/patch_realtek.c 2023-10-07 22:16:36.129618972 +1100 > +++ b/sound/pci/hda/patch_realtek.c 2023-10-07 22:16:52.645258218 +1100 > @@ -9412,6 +9412,7 @@ static const struct snd_pci_quirk alc269 > SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", > ALC289_FIXUP_DUAL_SPK), > SND_PCI_QUIRK(0x1028, 0x0b37, "Dell Inspiron 16 Plus 7620 > 2-in-1", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), > SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", > ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), > + SND_PCI_QUIRK(0x1028, 0x0beb, "Dell XPS 15 9530", > ALC289_FIXUP_DUAL_SPK), > SND_PCI_QUIRK(0x1028, 0x0c03, "Dell Precision 5340", > ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x0c19, "Dell Precision 3340", > ALC236_FIXUP_DELL_DUAL_CODECS), > SND_PCI_QUIRK(0x1028, 0x0c1a, "Dell Precision 3340", > ALC236_FIXUP_DELL_DUAL_CODECS), > I don't have much confidence that this patch request will meet the > requirements. Your Signed-off tag is needed, along with a commit title and message. Also Cc: maintainers.
