Thank you very much for your review, but there's something I'd like to discuss with you On Mon, Sep 25, 2023 at 16:06:18 +0200, broonie@xxxxxxxxxx wrote: > On Tue, Sep 19, 2023 at 06:57:21PM +0800, wangweidong.a@xxxxxxxxxx wrote: >> From: Weidong Wang <wangweidong.a@xxxxxxxxxx> >> >> Add aw87390 compatible code to the aw88395_lib.c file >> so that it can parse aw87390's bin file >> Modify the function return value > This breaks an x86 allmodconfig build: > /build/stage/linux/sound/soc/codecs/aw88395/aw88395.c: In function ‘aw88395_prof > ile_info’: > /build/stage/linux/sound/soc/codecs/aw88395/aw88395.c:199:21: error: too few arg > uments to function ‘aw88395_dev_get_prof_name’ > 199 | prof_name = aw88395_dev_get_prof_name(aw88395->aw_pa, count); > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from /build/stage/linux/sound/soc/codecs/aw88395/aw88395.c:17: > /build/stage/linux/sound/soc/codecs/aw88395/aw88395_device.h:184:5: note: declar > ed here > 184 | int aw88395_dev_get_prof_name(struct aw_device *aw_dev, int index, char > **prof_name); > | ^~~~~~~~~~~~~~~~~~~~~~~~~ I did not get this error when compiling base on "2cf0f715623872823a72e451243bbf555d10d032" and the changes to this function are already in [patch V4 3/7] Can you tell me how to modify it? Best regards, Weidong Wang
