On Fri, Sep 22, 2023 at 10:53:06PM +0530, Bragatheswaran Manickavel wrote: > > On 22/09/23 20:56, Conor Dooley wrote: > > On Fri, Sep 22, 2023 at 12:03:13AM +0530, Bragatheswaran Manickavel wrote: > > > Convert the tfa9879 audio CODEC bindings to DT schema > > > No error/warning seen when running make dt_binding_check > > > > > > Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@xxxxxxxxx> > > > Changes: > > > V1 -> V2: Fixed DT syntax errors and doc warning > > These should be under the --- line, not above it. > > Perhaps Mark will change it on application. > > Otherwise, > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Thanks for reviewing it. > Do I need to send a new patch by addressing the above comments ? To be clear, it's the changelog, not the sign off, that needs to go under the ---. It'd look like: Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@xxxxxxxxx> --- Changes: V1 -> V2: Fixed DT syntax errors and doc warning Mark often fixes these things when he applies patches, but sending a v2 w/ the changelog fixed might make his life easier. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
