On Tue, 19 Sep 2023 15:23:22 +0200, Peter Ujfalusi wrote: > > If a fixup is found via a quirk then the codec->fixup_name is only set if > CONFIG_SND_DEBUG_VERBOSE is enabled, otherwise the fixup_name is set to > NULL. > > This will result prints in __snd_hda_apply_fixup() when applying the found > fixup for example: > ehdaudio0D0: ALC236: Apply fix-func for (null) Are you sure this doesn't break? snd_pci_quirk.name is defined only when CONFIG_SND_DEBUG_VERBOSE=y. thanks, Takashi > Fixes: 73355ddd8775 ("ALSA: hda: Code refactoring snd_hda_pick_fixup()") > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx> > --- > sound/pci/hda/hda_auto_parser.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c > index 7c6b1fe8dfcc..7b1ddb8d40cb 100644 > --- a/sound/pci/hda/hda_auto_parser.c > +++ b/sound/pci/hda/hda_auto_parser.c > @@ -1043,9 +1043,8 @@ void snd_hda_pick_fixup(struct hda_codec *codec, > > found_device: > id = q->value; > -#ifdef CONFIG_SND_DEBUG_VERBOSE > name = q->name; > -#endif > + > codec_dbg(codec, "%s: picked fixup %s for %s %04x:%04x\n", > codec->core.chip_name, name ? name : "", > type, q->subvendor, q->subdevice); > -- > 2.42.0 >