On Tue, 26 Aug 2008 20:05:03 +0100, Mark Brown wrote:
> On Tue, Aug 26, 2008 at 06:06:56PM +0200, Jean Delvare wrote:
> > Convert the wm8750 codec driver to the new (standard) device driver
> > binding model.
>
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> for the wm8750 driver. I'm pretty confident the spitz change is correct
> too but don't have hardware to actually test.
>
> > /* spitz audio private data */
> > static struct wm8750_setup_data spitz_wm8750_setup = {
> > + .i2c_bus = 0,
> > .i2c_address = 0x1b,
> > };
>
> The assignment to 0 is redundant but it's useful for documentation.
I agree. Usually I am the first one to yell at people who explicitly
initialize struct members to 0, but in this specific case I think it is
a good idea to make sure that other developers notice the change.
--
Jean Delvare
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
