Hi Dan
Thank you for the report
> 5ca2ab4598179a Robert Hancock 2022-01-20 307 if (fixed_sysclk && props->mclk_fs) {
> 5ca2ab4598179a Robert Hancock 2022-01-20 308 unsigned int fixed_rate = fixed_sysclk / props->mclk_fs;
> 5ca2ab4598179a Robert Hancock 2022-01-20 309
> 5ca2ab4598179a Robert Hancock 2022-01-20 310 if (fixed_sysclk % props->mclk_fs) {
> 5ca2ab4598179a Robert Hancock 2022-01-20 311 dev_err(rtd->dev, "fixed sysclk %u not divisible by mclk_fs %u\n",
> 5ca2ab4598179a Robert Hancock 2022-01-20 312 fixed_sysclk, props->mclk_fs);
> 5ca2ab4598179a Robert Hancock 2022-01-20 @313 return -EINVAL;
>
> goto codec_err?
>
> 5ca2ab4598179a Robert Hancock 2022-01-20 314 }
> 5ca2ab4598179a Robert Hancock 2022-01-20 315 ret = snd_pcm_hw_constraint_minmax(substream->runtime, SNDRV_PCM_HW_PARAM_RATE,
> 5ca2ab4598179a Robert Hancock 2022-01-20 316 fixed_rate, fixed_rate);
> 635071f5fee315 Robert Hancock 2023-06-01 317 if (ret < 0)
> 5ca2ab4598179a Robert Hancock 2022-01-20 318 goto codec_err;
> fafc05aadd4b6c Kuninori Morimoto 2021-04-12 319 }
The correct fixup is not for line 313, but line 318,
but thank you for pointing it.
This issue itself is not related to "convert not to use asoc_xxx()"
patch. I will post separate patch with your sign.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
