On Wed, Sep 13, 2023 at 12:56:03PM +0200, Amadeusz Sławiński wrote: > On 9/12/2023 6:32 PM, Richard Fitzgerald wrote: > > +#ifdef CONFIG_PCI > > + /* > > + * PCI does not define 0 as invalid, so pci_subsystem_set indicates > > + * whether a value has been written to these fields. > > + */ > > + unsigned short pci_subsystem_vendor; > > + unsigned short pci_subsystem_device; > > + bool pci_subsystem_set; > > +#endif /* CONFIG_PCI */ > > + > > char topology_shortname[32]; > > struct device *dev; > This looks bit weird to me, snd_soc_card is _generic_ struct which is not > device specific in any way, and now you add fields for PCI, can't this > somehow be done using drvdata or something? You're right that it's a bit messy but if we use driver data then it becomes specific to a particular driver and there's a goal here to share with subfunction drivers. I was thinking we could refactor to a union or otherwise extend if we find other users with a similar need.
Attachment:
signature.asc
Description: PGP signature
