On Tue, Sep 12, 2023 at 10:14:57AM +0200, Herve Codina wrote:
> The given example mentions the 'fsl,mode' property whereas the
> correct property name, the one described, is 'fsl,operational-mode'.
>
> Fix the example to use the correct property name.
>
> Fixes: a9b121327c93 ("dt-bindings: soc: fsl: cpm_qe: Add QMC controller")
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> ---
> .../bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I have this same fix in my tree, but you missed something. Please add
additionalProperties or unevaluatedProperties to the child node schema
so that this error is flagged.
>
> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> index ec888f48cac8..450a0354cb1d 100644
> --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> @@ -137,7 +137,7 @@ examples:
> channel@16 {
> /* Ch16 : First 4 even TS from all routed from TSA */
> reg = <16>;
> - fsl,mode = "transparent";
> + fsl,operational-mode = "transparent";
> fsl,reverse-data;
> fsl,tx-ts-mask = <0x00000000 0x000000aa>;
> fsl,rx-ts-mask = <0x00000000 0x000000aa>;
> @@ -146,7 +146,7 @@ examples:
> channel@17 {
> /* Ch17 : First 4 odd TS from all routed from TSA */
> reg = <17>;
> - fsl,mode = "transparent";
> + fsl,operational-mode = "transparent";
> fsl,reverse-data;
> fsl,tx-ts-mask = <0x00000000 0x00000055>;
> fsl,rx-ts-mask = <0x00000000 0x00000055>;
> @@ -155,7 +155,7 @@ examples:
> channel@19 {
> /* Ch19 : 8 TS (TS 8..15) from all routed from TSA */
> reg = <19>;
> - fsl,mode = "hdlc";
> + fsl,operational-mode = "hdlc";
> fsl,tx-ts-mask = <0x00000000 0x0000ff00>;
> fsl,rx-ts-mask = <0x00000000 0x0000ff00>;
> };
> --
> 2.41.0
>
