Hi Julia
Thank you for the patch
> for_each_child_of_node performs an of_node_get on each
> iteration, so a break out of the loop requires an
> of_node_put.
>
> This was done using the Coccinelle semantic patch
> iterators/for_each_child.cocci
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxxx>
>
> ---
> sound/soc/sh/rcar/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -u -p a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
> --- a/sound/soc/sh/rcar/core.c
> +++ b/sound/soc/sh/rcar/core.c
> @@ -1303,6 +1303,7 @@ audio_graph:
> if (i >= RSND_MAX_COMPONENT) {
> dev_info(dev, "reach to max component\n");
> of_node_put(node);
> + of_node_put(ports);
> break;
> }
> }
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
I noticed that existing "of_node_put(node)" itself is not needed.
We can remove it, and I will post the patch next week.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
