Hi, kernel test robot noticed the following build errors: [auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on tiwai-sound/for-linus linus/master next-20230831] [cannot apply to broonie-sound/for-next v6.5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/cujomalainey-chromium-org/ALSA-core-add-snd_device_init/20230825-050745 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20230824210339.1126993-3-cujomalainey%40chromium.org patch subject: [PATCH 2/2] ALSA: core: split control primitives out of snd_card config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230904/202309040658.LwLeCNwY-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230904/202309040658.LwLeCNwY-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309040658.LwLeCNwY-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_get_volume1_vol': >> sound/core/oss/mixer_oss.c:542:24: error: 'struct snd_card' has no member named 'controls_rwsem' 542 | down_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:545:30: error: 'struct snd_card' has no member named 'controls_rwsem' 545 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:563:22: error: 'struct snd_card' has no member named 'controls_rwsem' 563 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_get_volume1_sw': sound/core/oss/mixer_oss.c:581:24: error: 'struct snd_card' has no member named 'controls_rwsem' 581 | down_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:584:30: error: 'struct snd_card' has no member named 'controls_rwsem' 584 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:603:22: error: 'struct snd_card' has no member named 'controls_rwsem' 603 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_put_volume1_vol': sound/core/oss/mixer_oss.c:647:24: error: 'struct snd_card' has no member named 'controls_rwsem' 647 | down_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:650:30: error: 'struct snd_card' has no member named 'controls_rwsem' 650 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:671:22: error: 'struct snd_card' has no member named 'controls_rwsem' 671 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_put_volume1_sw': sound/core/oss/mixer_oss.c:690:24: error: 'struct snd_card' has no member named 'controls_rwsem' 690 | down_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:693:30: error: 'struct snd_card' has no member named 'controls_rwsem' 693 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:718:22: error: 'struct snd_card' has no member named 'controls_rwsem' 718 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_get_recsrc2': sound/core/oss/mixer_oss.c:835:24: error: 'struct snd_card' has no member named 'controls_rwsem' 835 | down_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:863:22: error: 'struct snd_card' has no member named 'controls_rwsem' 863 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_put_recsrc2': sound/core/oss/mixer_oss.c:888:24: error: 'struct snd_card' has no member named 'controls_rwsem' 888 | down_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:919:22: error: 'struct snd_card' has no member named 'controls_rwsem' 919 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_build_test': sound/core/oss/mixer_oss.c:939:24: error: 'struct snd_card' has no member named 'controls_rwsem' 939 | down_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:942:30: error: 'struct snd_card' has no member named 'controls_rwsem' 942 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:947:30: error: 'struct snd_card' has no member named 'controls_rwsem' 947 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:952:30: error: 'struct snd_card' has no member named 'controls_rwsem' 952 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:957:22: error: 'struct snd_card' has no member named 'controls_rwsem' 957 | up_read(&card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_build_input': sound/core/oss/mixer_oss.c:1071:31: error: 'struct snd_card' has no member named 'controls_rwsem' 1071 | down_read(&mixer->card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:1080:45: error: 'struct snd_card' has no member named 'controls_rwsem' 1080 | up_read(&mixer->card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:1085:45: error: 'struct snd_card' has no member named 'controls_rwsem' 1085 | up_read(&mixer->card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:1101:61: error: 'struct snd_card' has no member named 'controls_rwsem' 1101 | up_read(&mixer->card->controls_rwsem); | ^~ sound/core/oss/mixer_oss.c:1113:29: error: 'struct snd_card' has no member named 'controls_rwsem' 1113 | up_read(&mixer->card->controls_rwsem); | ^~ -- In file included from include/linux/kernel.h:21, from arch/x86/include/asm/percpu.h:27, from arch/x86/include/asm/current.h:10, from include/linux/sched.h:12, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/pm_runtime.h:11, from sound/soc/intel/catpt/pcm.c:8: sound/soc/intel/catpt/pcm.c: In function 'catpt_dai_apply_usettings': >> sound/soc/intel/catpt/pcm.c:357:60: error: 'struct snd_card' has no member named 'controls' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~ include/linux/container_of.h:19:33: note: in definition of macro 'container_of' 19 | void *__mptr = (void *)(ptr); \ | ^~~ include/linux/list.h:531:9: note: in expansion of macro 'list_entry' 531 | list_entry((ptr)->next, type, member) | ^~~~~~~~~~ include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry' 689 | for (pos = list_first_entry(head, typeof(*pos), member); \ | ^~~~~~~~~~~~~~~~ sound/soc/intel/catpt/pcm.c:357:9: note: in expansion of macro 'list_for_each_entry' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ In file included from include/linux/bits.h:21, from include/linux/ratelimit_types.h:5, from include/linux/ratelimit.h:5: >> sound/soc/intel/catpt/pcm.c:357:60: error: 'struct snd_card' has no member named 'controls' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~ include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) | ^~~~ include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~~~ include/linux/container_of.h:20:23: note: in expansion of macro '__same_type' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~ include/linux/list.h:520:9: note: in expansion of macro 'container_of' 520 | container_of(ptr, type, member) | ^~~~~~~~~~~~ include/linux/list.h:531:9: note: in expansion of macro 'list_entry' 531 | list_entry((ptr)->next, type, member) | ^~~~~~~~~~ include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry' 689 | for (pos = list_first_entry(head, typeof(*pos), member); \ | ^~~~~~~~~~~~~~~~ sound/soc/intel/catpt/pcm.c:357:9: note: in expansion of macro 'list_for_each_entry' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ >> sound/soc/intel/catpt/pcm.c:357:60: error: 'struct snd_card' has no member named 'controls' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~ include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) | ^~~~ include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~~~ include/linux/container_of.h:21:23: note: in expansion of macro '__same_type' 21 | __same_type(*(ptr), void), \ | ^~~~~~~~~~~ include/linux/list.h:520:9: note: in expansion of macro 'container_of' 520 | container_of(ptr, type, member) | ^~~~~~~~~~~~ include/linux/list.h:531:9: note: in expansion of macro 'list_entry' 531 | list_entry((ptr)->next, type, member) | ^~~~~~~~~~ include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry' 689 | for (pos = list_first_entry(head, typeof(*pos), member); \ | ^~~~~~~~~~~~~~~~ sound/soc/intel/catpt/pcm.c:357:9: note: in expansion of macro 'list_for_each_entry' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ include/linux/compiler_types.h:338:27: error: expression in static assertion is not an integer 338 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) | ^~~~ include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~~~ include/linux/container_of.h:20:23: note: in expansion of macro '__same_type' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~ include/linux/list.h:520:9: note: in expansion of macro 'container_of' 520 | container_of(ptr, type, member) | ^~~~~~~~~~~~ include/linux/list.h:531:9: note: in expansion of macro 'list_entry' 531 | list_entry((ptr)->next, type, member) | ^~~~~~~~~~ include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry' 689 | for (pos = list_first_entry(head, typeof(*pos), member); \ | ^~~~~~~~~~~~~~~~ sound/soc/intel/catpt/pcm.c:357:9: note: in expansion of macro 'list_for_each_entry' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ In file included from include/linux/rculist.h:10, from include/linux/pid.h:5, from include/linux/sched.h:14: >> sound/soc/intel/catpt/pcm.c:357:60: error: 'struct snd_card' has no member named 'controls' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~ include/linux/list.h:680:27: note: in definition of macro 'list_entry_is_head' 680 | (&pos->member == (head)) | ^~~~ sound/soc/intel/catpt/pcm.c:357:9: note: in expansion of macro 'list_for_each_entry' 357 | list_for_each_entry(pos, &component->card->snd_card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ sound/soc/intel/catpt/pcm.c:362:63: error: 'struct snd_card' has no member named 'controls' 362 | if (list_entry_is_head(pos, &component->card->snd_card->controls, list)) | ^~ include/linux/list.h:680:27: note: in definition of macro 'list_entry_is_head' 680 | (&pos->member == (head)) | ^~~~ -- In file included from include/linux/kernel.h:21, from arch/x86/include/asm/percpu.h:27, from arch/x86/include/asm/current.h:10, from include/linux/sched.h:12, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/pm_runtime.h:11, from sound/soc/sh/rcar/core.c:93: sound/soc/sh/rcar/core.c: In function 'rsnd_kctrl_new': >> sound/soc/sh/rcar/core.c:1813:41: error: 'struct snd_card' has no member named 'controls' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~ include/linux/container_of.h:19:33: note: in definition of macro 'container_of' 19 | void *__mptr = (void *)(ptr); \ | ^~~ include/linux/list.h:531:9: note: in expansion of macro 'list_entry' 531 | list_entry((ptr)->next, type, member) | ^~~~~~~~~~ include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry' 689 | for (pos = list_first_entry(head, typeof(*pos), member); \ | ^~~~~~~~~~~~~~~~ sound/soc/sh/rcar/core.c:1813:9: note: in expansion of macro 'list_for_each_entry' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ In file included from include/linux/bits.h:21, from include/linux/ratelimit_types.h:5, from include/linux/ratelimit.h:5: >> sound/soc/sh/rcar/core.c:1813:41: error: 'struct snd_card' has no member named 'controls' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~ include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) | ^~~~ include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~~~ include/linux/container_of.h:20:23: note: in expansion of macro '__same_type' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~ include/linux/list.h:520:9: note: in expansion of macro 'container_of' 520 | container_of(ptr, type, member) | ^~~~~~~~~~~~ include/linux/list.h:531:9: note: in expansion of macro 'list_entry' 531 | list_entry((ptr)->next, type, member) | ^~~~~~~~~~ include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry' 689 | for (pos = list_first_entry(head, typeof(*pos), member); \ | ^~~~~~~~~~~~~~~~ sound/soc/sh/rcar/core.c:1813:9: note: in expansion of macro 'list_for_each_entry' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ >> sound/soc/sh/rcar/core.c:1813:41: error: 'struct snd_card' has no member named 'controls' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~ include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) | ^~~~ include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~~~ include/linux/container_of.h:21:23: note: in expansion of macro '__same_type' 21 | __same_type(*(ptr), void), \ | ^~~~~~~~~~~ include/linux/list.h:520:9: note: in expansion of macro 'container_of' 520 | container_of(ptr, type, member) | ^~~~~~~~~~~~ include/linux/list.h:531:9: note: in expansion of macro 'list_entry' 531 | list_entry((ptr)->next, type, member) | ^~~~~~~~~~ include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry' 689 | for (pos = list_first_entry(head, typeof(*pos), member); \ | ^~~~~~~~~~~~~~~~ sound/soc/sh/rcar/core.c:1813:9: note: in expansion of macro 'list_for_each_entry' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ include/linux/compiler_types.h:338:27: error: expression in static assertion is not an integer 338 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert' 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) | ^~~~ include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~~~ include/linux/container_of.h:20:23: note: in expansion of macro '__same_type' 20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \ | ^~~~~~~~~~~ include/linux/list.h:520:9: note: in expansion of macro 'container_of' 520 | container_of(ptr, type, member) | ^~~~~~~~~~~~ include/linux/list.h:531:9: note: in expansion of macro 'list_entry' 531 | list_entry((ptr)->next, type, member) | ^~~~~~~~~~ include/linux/list.h:689:20: note: in expansion of macro 'list_first_entry' 689 | for (pos = list_first_entry(head, typeof(*pos), member); \ | ^~~~~~~~~~~~~~~~ sound/soc/sh/rcar/core.c:1813:9: note: in expansion of macro 'list_for_each_entry' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ In file included from include/linux/rculist.h:10, from include/linux/pid.h:5, from include/linux/sched.h:14: >> sound/soc/sh/rcar/core.c:1813:41: error: 'struct snd_card' has no member named 'controls' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~ include/linux/list.h:680:27: note: in definition of macro 'list_entry_is_head' 680 | (&pos->member == (head)) | ^~~~ sound/soc/sh/rcar/core.c:1813:9: note: in expansion of macro 'list_for_each_entry' 1813 | list_for_each_entry(kctrl, &card->controls, list) { | ^~~~~~~~~~~~~~~~~~~ vim +542 sound/core/oss/mixer_oss.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 529 f956b4a3ae790e Takashi Iwai 2005-11-17 530 static void snd_mixer_oss_get_volume1_vol(struct snd_mixer_oss_file *fmixer, f956b4a3ae790e Takashi Iwai 2005-11-17 531 struct snd_mixer_oss_slot *pslot, ^1da177e4c3f41 Linus Torvalds 2005-04-16 532 unsigned int numid, ^1da177e4c3f41 Linus Torvalds 2005-04-16 533 int *left, int *right) ^1da177e4c3f41 Linus Torvalds 2005-04-16 534 { f956b4a3ae790e Takashi Iwai 2005-11-17 535 struct snd_ctl_elem_info *uinfo; f956b4a3ae790e Takashi Iwai 2005-11-17 536 struct snd_ctl_elem_value *uctl; f956b4a3ae790e Takashi Iwai 2005-11-17 537 struct snd_kcontrol *kctl; f956b4a3ae790e Takashi Iwai 2005-11-17 538 struct snd_card *card = fmixer->card; ^1da177e4c3f41 Linus Torvalds 2005-04-16 539 ^1da177e4c3f41 Linus Torvalds 2005-04-16 540 if (numid == ID_UNKNOWN) ^1da177e4c3f41 Linus Torvalds 2005-04-16 541 return; ^1da177e4c3f41 Linus Torvalds 2005-04-16 @542 down_read(&card->controls_rwsem); b1e055f67611da Takashi Iwai 2023-07-18 543 kctl = snd_ctl_find_numid_locked(card, numid); 51c816fdd17c63 Takashi Iwai 2021-06-08 544 if (!kctl) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 545 up_read(&card->controls_rwsem); ^1da177e4c3f41 Linus Torvalds 2005-04-16 546 return; ^1da177e4c3f41 Linus Torvalds 2005-04-16 547 } ca2c0966562cfb Takashi Iwai 2005-09-09 548 uinfo = kzalloc(sizeof(*uinfo), GFP_KERNEL); ca2c0966562cfb Takashi Iwai 2005-09-09 549 uctl = kzalloc(sizeof(*uctl), GFP_KERNEL); ^1da177e4c3f41 Linus Torvalds 2005-04-16 550 if (uinfo == NULL || uctl == NULL) ^1da177e4c3f41 Linus Torvalds 2005-04-16 551 goto __unalloc; 7c22f1aaa23370 Takashi Iwai 2005-10-10 552 if (kctl->info(kctl, uinfo)) 7c22f1aaa23370 Takashi Iwai 2005-10-10 553 goto __unalloc; 7c22f1aaa23370 Takashi Iwai 2005-10-10 554 if (kctl->get(kctl, uctl)) 7c22f1aaa23370 Takashi Iwai 2005-10-10 555 goto __unalloc; 7c22f1aaa23370 Takashi Iwai 2005-10-10 556 if (uinfo->type == SNDRV_CTL_ELEM_TYPE_BOOLEAN && 7c22f1aaa23370 Takashi Iwai 2005-10-10 557 uinfo->value.integer.min == 0 && uinfo->value.integer.max == 1) 7c22f1aaa23370 Takashi Iwai 2005-10-10 558 goto __unalloc; ^1da177e4c3f41 Linus Torvalds 2005-04-16 559 *left = snd_mixer_oss_conv1(uctl->value.integer.value[0], uinfo->value.integer.min, uinfo->value.integer.max, &pslot->volume[0]); ^1da177e4c3f41 Linus Torvalds 2005-04-16 560 if (uinfo->count > 1) ^1da177e4c3f41 Linus Torvalds 2005-04-16 561 *right = snd_mixer_oss_conv1(uctl->value.integer.value[1], uinfo->value.integer.min, uinfo->value.integer.max, &pslot->volume[1]); ^1da177e4c3f41 Linus Torvalds 2005-04-16 562 __unalloc: ^1da177e4c3f41 Linus Torvalds 2005-04-16 563 up_read(&card->controls_rwsem); ^1da177e4c3f41 Linus Torvalds 2005-04-16 564 kfree(uctl); ^1da177e4c3f41 Linus Torvalds 2005-04-16 565 kfree(uinfo); ^1da177e4c3f41 Linus Torvalds 2005-04-16 566 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 567 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
