On 24-08-08 18:08, Krzysztof Helt wrote: > From: Krzysztof Helt <krzysztof.h1@xxxxx> > > Use the wss_dout function which does not mess > shadowed register values during chip probing. > Otherwise, user ends up with stupid mixer settings > after driver loading. > > Signed-off-by: Krzysztof Helt <krzysztof.h1@xxxxx> Acked-by: Rene Herman <rene.herman@xxxxxxxxx> Must say that I only now notice that we're doing that init loop there. I believe it could be better to introduce an inline __snd_wss_out() with just the two outb()s and use that from snd_wss_out() and here directly. And with respect to the mb() ... if anywhere, should't that be between the two outb's really? Rene. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel