On Tue, Aug 29, 2023 at 04:02:38PM +0200, Takashi Iwai wrote:
> On Tue, 29 Aug 2023 15:52:52 +0200,
> Andy Shevchenko wrote:
> >
> > Instead of reiterating the list, use list_for_each_entry_safe()
> > that allows to continue without starting over.
> Through a quick glance, it should be OK, but I need to read and
> understand whether this change is perfectly safe or not -- unless
> Jaroslav gives his review and ack.
Sure.
> > ---
> >
> > Takashi, if you have anybody or want yourself to spend some time,
> > I believe you can simplify a lot the parser in this file with
> > the help of lib/cmdline.c APIs.
>
> Thanks for the hint. Yeah, it looks feasible, but too late for 6.6,
> it's a nice TODO ;)
Of course.
Just a reference what I did to gpio-aggregator module:
ac505b6f5fa8 ("gpio: aggregator: Replace custom get_arg() with a generic next_arg()")
deb631c40114 ("gpio: aggregator: Replace isrange() by using get_options()")
--
With Best Regards,
Andy Shevchenko
