Hi Andy Shevchenko, > Subject: Re: [PATCH] mfd: madera-i2c: Simplify probe() > > On Sat, Aug 26, 2023 at 10:17:51AM +0100, Biju Das wrote: > > Simplify probe() by replacing of_device_get_match_data() and ID lookup > > for retrieving match data by i2c_get_match_data(). > > ... > > > - of_data = of_device_get_match_data(&i2c->dev); > > - if (of_data) > > - type = (unsigned long)of_data; > > - else > > - type = id->driver_data; > > + type = (unsigned long)i2c_get_match_data(i2c); > > > > > This blank line is not needed after this change. Agreed, will remove it. Cheers, Biju
