On Sun, Aug 27, 2023 at 11:21:14AM +0100, Biju Das wrote:
> Simplify probe() by replacing of_match_device->i2c_get_match_data() and
> extend matching support for ID table.
...
> - return -EINVAL;
> + return dev_err_probe(-ENODEV);
Commit message doesn't explain this change.
...
> +static const struct of_device_id wm8580_of_match[] = {
> + { .compatible = "wlf,wm8580", .data = &wm8580_data },
> + { .compatible = "wlf,wm8581", .data = &wm8581_data },
> + { },
Do not put comma in the terminator entry. It's illogical.
> +};
--
With Best Regards,
Andy Shevchenko
