Mark Brown <broonie@xxxxxxxxxx> writes: >> To properly support a line of Huawei laptops with AMD CPU and a >> ES8336 codec connected to the ACP3X module we need to enable >> the S32 LE format. > > What's the issue? The AMD code looks like it supports plenty of other > formats in most places. In previous version of the machine driver I used a different CPU component than acp-i2s-sp. For that one, I couldn't get it to have sound unless I specifically requested S32 LE format. I removed S32_LE from the CODEC to test if it works and it seems it does work with acp-is2-sp. Format S16_LE is chosen by both components and sound can be heard. I guess this patch is not really needed.
