Re: [PATCH RFC 0/9] ALSA: Don't embed struct devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 16, 2023 at 9:45 AM Jaroslav Kysela <perex@xxxxxxxx> wrote:
>
> On 16. 08. 23 18:02, Takashi Iwai wrote:
> > Hi,
> >
> > this is another set of patches to attempt papering over the UAF
> > problems that are seen when the delayed kobject release is enabled, as
> > initially reported by Curtis:
> >    https://lore.kernel.org/r/20230801171928.1460120-1-cujomalainey@xxxxxxxxxxxx
> >
> > There was a previous patch set with a different approach (using the
> > device refcount dependencies), but this is a sort of step-back to the
> > old way.
> >    https://lore.kernel.org/r/20230807135207.17708-1-tiwai@xxxxxxx
> >
> > After discussions and evaluations, we agreed that decoupling the
> > struct device from each sound component object is the safest (and
> > easiest) way as of now.  For applying the changes more consistently, I
> > introduced a new helper for the struct device allocation and
> > initialization, and applied all components.
> >
> > A couple of more changes for card_dev refcount managed aren't included
> > in this patch set, though.  They might be good to have, but this patch
> > set should suffice for the currently seen UAF problems.
> >
> > For a long-term solution, we may restructure the device management,
> > then the struct devices may be embedded again in each object.  But,
> > it'll need lots of other changes and cleanups, a big TODO.

I agree I think we should apply this as proper fixes will be a big
lift. Thanks for refining them.

> >
> > The latest patches are found in topic/dev-split branch of sound.git
> > tree.
> >
> >
> > Takashi
> >
> > ===
> >
> > Takashi Iwai (9):
> >    ALSA: core: Introduce snd_device_alloc()
> >    ALSA: control: Don't embed ctl_dev
> >    ALSA: pcm: Don't embed device
> >    ALSA: hwdep: Don't embed device
> >    ALSA: rawmidi: Don't embed device
> >    ALSA: compress: Don't embed device
> >    ALSA: timer: Create device with snd_device_alloc()
> >    ALSA: seq: Create device with snd_device_alloc()
> >    ALSA: core: Drop snd_device_initialize()
>
> For all commits:
>
> Reviewed-by: Jaroslav Kysela <perex@xxxxxxxx>
>
> --
> Jaroslav Kysela <perex@xxxxxxxx>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
>

For all

Signed-off-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx>
Tested-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx>




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux