Re: [PATCH v2] ALSA: hda: intel-dsp-cfg: Add Chromebook quirk to ADL/RPL

[Curtis Malainey <cujomalainey@xxxxxxxxxx>]

On Tue, Aug 15, 2023 at 8:56 AM Pierre-Louis Bossart <
pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote:

>
>
> On 8/15/23 08:52, Brady Norander wrote:
> > AlderLake and RaptorLake Chromebooks currently use the HDA driver by
> > default. Add a quirk to use the SOF driver on these platforms, which is
> > needed for functional internal audio.
> >
> > Signed-off-by: Brady Norander <bradynorander@xxxxxxxxx>
>
> Thanks for the patch
>
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
>

Now that I am looking closer at the patch, I am very curious why we are not
hitting the following case and using SOF

         {




                 .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,




                 .device = PCI_DEVICE_ID_INTEL_HDA_ADL_P,




         },
         {




                 .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,




                 .device = PCI_DEVICE_ID_INTEL_HDA_ADL_N,




         },
etc.

This makes me wonder if maybe the DMIC detection is actually broken.

Curtis