On Mon, 14 Aug 2023 16:47:05 +0200, Cezary Rojewski wrote: > > On 2023-08-14 4:41 PM, Takashi Iwai wrote: > > On Fri, 11 Aug 2023 18:48:41 +0200, > > Cezary Rojewski wrote: > >> > >> Introduce a set of functions that facilite SDxFMT-related calculations > >> in atomic manner: > >> > >> snd_hdac_format_normalize() - format converter. S20_LE, S24_LE and their > >> unsigned and BE friends are invalid from HDAudio perspective but still > >> can be specified as function argument due to compatibility reasons. > > > > Which compatibility reason? Those formats should have been never used > > for HD-audio codecs at the first place, so shouldn't it rather return > > an error? > > In regard to avs-driver we can "force" the S24_LE out, no > problem. However, I do not believe the same is true for the > skylake-driver. I agree, S24_LE and its friends should not have been > used, but they were. Hm, if those formats are actually passed to the codec side, then it's rather a bug, I suppose. It can be used for the controller where DSP converts the format, though. Takashi
