On Fri, 15 Aug 2008, Takashi Iwai wrote:
> At Fri, 15 Aug 2008 12:39:19 +0200 (CEST),
> noreply-git@xxxxxxxxxxxxxxxx wrote:
> >
> > @@ -362,10 +363,8 @@ static int snd_card_dummy_playback_open(struct snd_pcm_substream *substream)
> > }
> > if (substream->pcm->device & 2)
> > runtime->hw.info &= ~(SNDRV_PCM_INFO_MMAP|SNDRV_PCM_INFO_MMAP_VALID);
> > - if ((err = add_playback_constraints(runtime)) < 0) {
> > - kfree(dpcm);
> > + if ((err = add_playback_constraints(runtime)) < 0)
> > return err;
> > - }
>
> Run checkpatch.pl please...
The patch conformed to coding style in dummy.c. I commited new patch on
top of this patch to remove (almost all) assignments in if conditions..
Jaroslav
-----
Jaroslav Kysela <perex@xxxxxxxx>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
