Re: [PATCH] ASoC: lower "no backend DAIs enabled for ... Port" log severity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Maybe, but it's a questionable flow if pipewire tries to open stuff
without the mixer values set-up. Is there something done about this?

I'm working with the pipewire folks to see if we can fix this on
pipewire's side too:

Link: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3407

I think it's an oft-seen problem when user runs the system without
installing a proper UCM profile.

The reason why I am pushing back is that we had a similar issue with
HDaudio where HDMI/DP PCM devices were opened without checking if the
jack was connected.

It really makes no sense for userspace to try and open devices that are
known to be problematic. We can push kernel error logs below the rug, it
doesn't make the programming flows better.

Downgrading the message also hides to show what's wrong there.
Although the message doesn't indicate how to fix the problem, no
message would make debug harder.

So in general I agree that it's annoying and it should be fixed, but
hiding all as default can be bad, too.  Maybe we can introduce a
counter and shut out after three strikes?

Right, this also happens with unsupported codecs (either unsupported in the kernel or no UCM profile available yet). So making this less "chatty" would be good.

I would prefer to just go for only log this once rather then
three strikes though, then we can simply use 'dev_err_once()'
for this.

I'd be fine with dev_err_once(). In general when you have this error it's a telltale sign that a configuration is missing. Repeating the message does not makes things better.

Maybe also add some information for the user, e.g. "ASoC: no backend DAIs enabled for Baytrail Audio Port, possibly missing ALSA mixer-based routing or UCM profile"




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux