Hi Trevor
Thank you for your review.
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> > ALSA SoC merges DAI call backs into .ops.
> > This patch merge thesse into one.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > ---
(snip)
> Why are you including mtk_dai_hdmitx_dptx_ops2 and keeping
> mtk_dai_hdmitx_dptx_ops even though you are not using it?
Because there are 2 users of mtk_dai_hdmitx_dptx_ops (A),
one needs .probe (B)
static struct snd_soc_dai_driver mtk_dai_etdm_driver[] = {
{
.name = "DPTX",
.id = MT8195_AFE_IO_DPTX,
...
(A) .ops = &mtk_dai_hdmitx_dptx_ops,
},
...
{
.name = "ETDM3_OUT",
.id = MT8195_AFE_IO_ETDM3_OUT,
...
(A) .ops = &mtk_dai_hdmitx_dptx_ops,
(B) .probe = mtk_dai_etdm_probe,
},
};
mtk_dai_hdmitx_dptx_ops = (A)
mtk_dai_hdmitx_dptx_ops2 = (A) + (B)
Thank you for your help !!
Best regards
---
Kuninori Morimoto
