Re: [PATCH v3 3/6] ASoC: mediatek: mt7986: add platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 28/07/23 11:08, Maso Huang ha scritto:
Add mt7986 platform driver.

Signed-off-by: Maso Huang <maso.huang@xxxxxxxxxxxx>
---
  sound/soc/mediatek/Kconfig                 |  10 +
  sound/soc/mediatek/Makefile                |   1 +
  sound/soc/mediatek/mt7986/Makefile         |   8 +
  sound/soc/mediatek/mt7986/mt7986-afe-pcm.c | 622 +++++++++++++++++++++
  4 files changed, 641 insertions(+)
  create mode 100644 sound/soc/mediatek/mt7986/Makefile
  create mode 100644 sound/soc/mediatek/mt7986/mt7986-afe-pcm.c


..snip..

+	/* register component */
+	ret = devm_snd_soc_register_component(&pdev->dev,
+					      &mt7986_afe_component,
+					      NULL, 0);
+	if (ret)
+		return dev_err_probe(dev, ret, "err_platform\n");

I know I only said about using dev_err_probe(), but "err_platform" doesn't
mean anything!

Please write a human readable error message, like "Cannot register AFE component\n"

+
+	ret = devm_snd_soc_register_component(afe->dev,
+					      &mt7986_afe_pcm_dai_component,
+					      afe->dai_drivers,
+					      afe->num_dai_drivers);
+	if (ret)
+		return dev_err_probe(dev, ret, "err_dai_component\n");

And the same here, "Cannot register PCM DAI component\n"

After which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux